Editor: Restore isCleanNewPost selector #9668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
[Type] Plugin Interoperability
|
This fixes the issue with Divi for me. 👍 |
aduth
force-pushed
the
restore/is-clean-new-post-selector
branch
from
1ca81d1 to
cca95ab
Compare
Thanks for the reminder. Updated in rebased cca95ab. |
|
Update looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #8831
Related Slack conversation: https://wordpress.slack.com/archives/C02QB2JS7/p1536218969000100?thread_ts=1536160199.000100&cid=C02QB2JS7 (link requires registration)
This pull request seeks to restore an
isCleanNewPostselector which was previously removed as part of the removal of its sole consumer within the editor package. It has surfaced that there were third-party integrations which depended upon this selector. As no alternative exists and it appears to be a useful selector for integrations, it has been restored here. A note has been included to indicate that it is not in use by the editor package itself.Testing instructions:
There is no impact on the application.
Ensure unit tests pass:
cc @ZebulanStanphill